Reduce node-state serialization overhead - #14
Draft
the-code-learner wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
First profile-driven Zephyr performance experiment, stacked on the Consensus & Performance Lab PR.
The canonical 7-validator profile shows the current persistence hot path dominates before P-256 verification:
ledger.(*Store).writeState: ~58% cumulative CPUencoding/json.MarshalIndent: ~55% cumulative CPUMarshalIndent: ~41% of flat allocations in the profiled processStore.Accept: ~90% cumulative mutex delayExperiment
Replace machine-only
state.jsonserialization fromjson.MarshalIndentto compactjson.Marshalwhile preserving:Measurement
The PR temporarily runs baseline and optimized canonical 7-validator benchmarks in the same GitHub-hosted job with the same runner, workload and
-benchtime=5x, then verifiesgo vet ./..., the full Go suite and the Consensus & Performance Lab before committing the experiment.This is deliberately not the journal/checkpoint redesign yet. It isolates how much of the current bottleneck is purely pretty-printed full-state JSON serialization before we make a larger storage-architecture change.