Skip to content

Prevent multiple calls to part.getTable method #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
th3nate wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Prevent multiple calls to part.getTable method #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/service/loader-partial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ angular.module('pascalprecht.translate')
function $translatePartialLoader() {

'use strict';


var loadedParts = []; //-> holds the already loaded parts to make sure we wontload them again.

/**
* @constructor
* @name Part
Expand Down Expand Up @@ -298,10 +300,13 @@ function $translatePartialLoader() {
prioritizedParts = getPrioritizedParts();

angular.forEach(prioritizedParts, function(part) {
loaders.push(
part.getTable(options.key, $q, $http, options.$http, options.urlTemplate, errorHandler)
);
part.urlTemplate = options.urlTemplate;
if(!_.contains(loadedParts, part.name)){ //-> check if translation was loaded before, if not go ahead and load
loaders.push(
part.getTable(options.key, $q, $http, options.$http, options.urlTemplate, errorHandler)
);
loadedParts.push(part.name); //-> register the loaded part so it won't be loaded again
part.urlTemplate = options.urlTemplate;
}
});

return $q.all(loaders)
Expand Down