Skip to content

fix(codex): honor configured ACP profile#183

Merged
onutc merged 2 commits intomainfrom
codex-explicit-gateway-profile
Mar 31, 2026
Merged

fix(codex): honor configured ACP profile#183
onutc merged 2 commits intomainfrom
codex-explicit-gateway-profile

Conversation

@onutc
Copy link
Copy Markdown
Member

@onutc onutc commented Mar 31, 2026

Summary

  • pass an explicitly configured Codex profile through the ACP runtime command builder
  • add a regression test that captures fresh and resumed codex exec argv
  • keep the change generic so deployment overlays can provide their own profile names

Testing

  • node --test examples/codex/acp-server.test.mjs
  • bash images/examples/codex/entrypoint_test.sh

@onutc onutc merged commit 89aef81 into main Mar 31, 2026
1 check passed
@onutc onutc deleted the codex-explicit-gateway-profile branch March 31, 2026 15:13
@gitrank-connector
Copy link
Copy Markdown

👍 GitRank PR Analysis

Score: 20 points

Metric Value
Component Other (1× multiplier)
Severity P2 - Medium (20 base pts)
Final Score 20 × 1 = 20

Eligibility Checks

Check Status
Issue/Bug Fix
Fix Implementation
PR Documented
Tests
Lines Within Limit

Impact Summary

This PR fixes a bug where the Codex ACP runtime was not passing explicitly configured profiles to the command builder. The fix adds support for the SPRITZ_CODEX_PROFILE environment variable and ensures the profile is correctly passed via the -p flag to both fresh and resumed exec calls. A comprehensive regression test is included that validates profile arguments are present in both execution paths.

Analysis Details

Component Classification: This PR affects the Codex ACP runtime configuration system, which doesn't fit neatly into standard categories. It's classified as OTHER since it's a configuration/runtime enhancement rather than a core platform component.

Severity Justification: Classified as P2 (Medium) because this fixes a functional bug where configured ACP profiles were not being honored in the Codex runtime. While not a critical service outage, it prevents proper configuration of deployment overlays and represents a functional regression that requires a workaround.

Eligibility Notes: Issue: True - PR title explicitly states 'fix' and describes a configuration bug. Fix Implementation: True - code changes correctly implement profile passing through environment variable and command builder. PR Linked: True - clear summary and testing instructions provided. Tests: True - 89 lines of new test code added with regression test covering both fresh and resumed execution. Tests Required: True - this is a bug fix in business logic (runtime command building) that requires regression testing to prevent future breakage.


Analyzed by GitRank 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant