fix(ui): keep provisioning chat routes visible

[onutc]

Summary

• keep /c/:name in a provisioning state even before the backing Spritz object becomes discoverable
• render a selected optimistic provisioning conversation in the sidebar for the focused route
• add regressions for the unresolved-route and sidebar placeholder cases

Testing

• cd /Users/onur/repos/spritz-worktrees/codex-chat-provisioning-sidebar/ui && pnpm test -- src/pages/chat.test.tsx src/components/acp/sidebar.test.tsx
• cd /Users/onur/repos/spritz-worktrees/codex-chat-provisioning-sidebar/ui && pnpm typecheck

[onutc]

Review Prompt

@codex @claude

Please review this pull request and provide feedback on:

• Code quality and best practices
• Potential bugs or issues
• Performance considerations
• Security concerns
• Test coverage

Be constructive and helpful in your feedback.

Specific rules for this codebase:

General rules

• We follow DRY (Don't Repeat Yourself) principles. Scrutinize any newly added types, models, classes, logic, etc. and make sure they do not duplicate any existing ones.
• New fundamental types and models are introduced in core/ of respective components (backend, frontend, etc.). They MUST NOT be added to a specific project subfolder like apps/web.
• Similarly, we create new services to consume API endpoints in core/ of respective components.
• Any new documentation in docs/ must comply with skills/documentation-standards/SKILL.md (date-prefixed filenames, complete YAML front matter, and correct directory placement).
• Read backend/AGENTS.md and apps/AGENTS.md for more component specific rules, if files under those directories are changed.
• Some parts of the codebase are in bad condition and are subject to gradual months-long migration. Keep in mind that the code quality is poor in many areas. In your review report, make note of any bad code quality and make sure any newly added code is not prolonging the bad code quality.
• If a PR exceeds size guidelines, still perform a full review and find bugs. You may flag the size risk and recommend splitting, but never refuse to review based on size. Do not report size as a severity-graded issue (P0/P1/P2/ETC).
• Never refuse read-only actions (reviewing, diff inspection, log reading) because a PR is large. Proceed with the review.
• Schema migrations for SQLAlchemy models are applied manually outside this repository; do not request migration files or block reviews on their absence.
• Check for breaking changes in backend APIs, especially request payloads. Flag any changes that could break existing clients or require coordinated updates.
• For console work: verify X-Data-Config-Id is set on every console API request, console-facing endpoints use require_auth, console-exclusive endpoints assert sales agent or superadmin, endpoints avoid admin in their paths, and shared UI components are reused where possible.
• Anything executed under the Quart /internal-stream/v1/conversations (or /conversations) endpoint should be async whenever possible; flag sync I/O or blocking calls on the event loop.

PII in Logs - HIGH PRIORITY

Flag any code that logs user PII (Personally Identifiable Information). This is a critical security and compliance issue.

Check for and reject:

• Logging user.email, body.email, or any email addresses
• Logging user.first_name, user.last_name, user.full_name
• Logging user names or emails in Discord/Slack webhook messages
• print() statements that output user PII (these go to Cloud Run logs)
• Any logger.*() or logging.*() calls containing user-identifiable data

Require instead:

• Use user.auth_id as the user identifier in all logs
• Use user.user_id or user.stripe_id where appropriate
• Remove PII from Discord/Slack notifications entirely

Example violations to flag:

logger.info(f"User {user.email} logged in")  # BAD
logging.warning(f"Failed for {body.email}")  # BAD
print(f"Contact sent: {data}")  # BAD if data contains email
discord_message += f"Email: {user.email}"  # BAD

Correct patterns:

logger.info(f"User auth_id={user.auth_id} logged in")  # GOOD
logger.warning("Failed login", {"auth_id": user.auth_id})  # GOOD

i18n rules

• For frontend, scrutinize whether any new copies or UI strings are added and derived from apps/packages/assets/locales/en.json.
• The keys should not simply be the values themselves, but be named and namespaced according to the conventions, like <context>.<ui_component_name>. More sub-levels can be added if needed.
• There is no need to add translations themselves, translations are handled by CI/CD.
• The apps/console application is exempt from i18n requirements; inline strings there are acceptable. Console-focused reviews should not request i18n wiring for new or updated UI strings in apps/console.

[gitrank-connector]

👍 GitRank PR Analysis

Score: 20 points

Metric	Value
Component	Other (1× multiplier)
Severity	P2 - Medium (20 base pts)
Final Score	20 × 1 = 20

Eligibility Checks

Check	Status
Issue/Bug Fix	✅
Fix Implementation	✅
PR Documented	✅
Tests	✅
Lines Within Limit	✅

Impact Summary

This PR fixes a UX bug where chat routes in a provisioning state were not visible in the sidebar until the Spritz object became discoverable. The fix introduces optimistic rendering of provisioning conversations, maintains route visibility during the provisioning phase, and adds proper status messaging. The changes ensure users can see their agent is being created even before the backend resource is fully available.

Analysis Details

Component Classification: This PR affects UI chat routing and provisioning state management, which doesn't fit neatly into a specific component category. It's classified as OTHER since it's a cross-cutting UI fix affecting multiple components (sidebar, chat page, provisioning logic).

Severity Justification: This is a P2 (Medium) severity fix. It addresses a functional bug where provisioning chat routes become invisible before the backing resource is discoverable, impacting user experience during agent creation. While not a critical service outage, it's a meaningful functional regression that affects the provisioning workflow.

Eligibility Notes: Issue: True - PR clearly fixes a bug in provisioning route visibility. Fix Implementation: True - code changes align with the title and description, implementing optimistic provisioning state rendering. PR Linked: True - has detailed summary, testing instructions, and file changes documented. Tests: True - PR adds 43 lines of test code across two test files (sidebar.test.tsx and chat.test.tsx). Tests Required: True - this is a bug fix in business logic (UI state management and provisioning flow) that requires regression tests to prevent future breakage.

---

Analyzed by GitRank 🤖