Skip to content

feat(ui): support direct agent chat routes#169

Merged
onutc merged 1 commit intomainfrom
codex-ui-agent-chat-routes
Mar 27, 2026
Merged

feat(ui): support direct agent chat routes#169
onutc merged 1 commit intomainfrom
codex-ui-agent-chat-routes

Conversation

@onutc
Copy link
Copy Markdown
Member

@onutc onutc commented Mar 27, 2026

Summary

  • make /c/:name usable before ACP is ready by showing provisioning state, polling until ready, and starting a chat automatically
  • when the route omits a conversation id, load the latest conversation if one exists or create a new one if it does not
  • focus the routed agent in the sidebar, move it to the top, and collapse the other agent sections by default

Testing

  • cd ui && pnpm test -- src/pages/chat.test.tsx src/components/acp/sidebar.test.tsx
  • cd ui && pnpm typecheck

@onutc onutc merged commit 93992d8 into main Mar 27, 2026
1 check passed
@onutc onutc deleted the codex-ui-agent-chat-routes branch March 27, 2026 09:10
@gitrank-connector
Copy link
Copy Markdown

👍 GitRank PR Analysis

Score: 20 points

Metric Value
Component Other (1× multiplier)
Severity P2 - Medium (20 base pts)
Final Score 20 × 1 = 20

Eligibility Checks

Check Status
Issue/Bug Fix
Fix Implementation
PR Documented
Tests
Lines Within Limit

Impact Summary

The PR enables direct agent chat routes via /c/:name by adding provisioning state display, automatic polling until readiness, and automatic conversation creation/selection. It enhances the sidebar to focus routed agents at the top and collapse other sections. The implementation includes comprehensive test coverage for the new routing and sidebar behaviors.

Analysis Details

Component Classification: This PR affects UI chat routing and sidebar components without fitting neatly into a single categorized component, making OTHER the appropriate classification.

Severity Justification: This is a P2 (Medium) severity contribution as it implements a functional feature enhancement (direct agent chat routes with provisioning state) that improves user experience but doesn't fix a critical bug or security issue.

Eligibility Notes: Tests are required and included: 89 new lines in sidebar.test.tsx and 193 new lines in chat.test.tsx covering provisioning states, conversation selection, auto-creation, and sidebar focus behavior. The PR is well-documented with clear description of changes. No reported issue is referenced, but this is a feature implementation rather than a bug fix. The fix_implementation check passes as code changes align with the feature description.


Analyzed by GitRank 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant