Skip to content

feat(images): migrate openclaw acp runtime to typescript#161

Merged
onutc merged 2 commits intomainfrom
codex-spritz-acp-runtime-ts
Mar 25, 2026
Merged

feat(images): migrate openclaw acp runtime to typescript#161
onutc merged 2 commits intomainfrom
codex-spritz-acp-runtime-ts

Conversation

@onutc
Copy link
Copy Markdown
Member

@onutc onutc commented Mar 25, 2026

This moves the generic OpenClaw ACP runtime and shared ACP server into the Spritz example image build as proper TypeScript sources with a real compile step. It also keeps live tool/thought streaming prompt-scoped instead of replaying stale transcript state, and adds upstream tests plus CI coverage for the example runtime image.

@onutc onutc merged commit 859432a into main Mar 25, 2026
1 check passed
@onutc onutc deleted the codex-spritz-acp-runtime-ts branch March 25, 2026 22:22
@gitrank-connector
Copy link
Copy Markdown

👍 GitRank PR Analysis

Score: 5 points

Metric Value
Component Other (1× multiplier)
Severity P3 - Low (5 base pts)
Final Score 5 × 1 = 5

Eligibility Checks

Check Status
Issue/Bug Fix
Fix Implementation
PR Documented
Tests
Lines Within Limit

Impact Summary

This PR migrates the OpenClaw ACP runtime from JavaScript to TypeScript with proper compilation, adds comprehensive test coverage including new CI workflows, and refactors gateway proxy logic into a dedicated module. The changes improve code quality, type safety, and maintainability while keeping live tool/thought streaming prompt-scoped rather than replaying stale transcript state. The PR includes 3622 total lines changed across 21 files with new test files and CI integration.

Analysis Details

Component Classification: This PR is a refactoring/modernization effort that migrates JavaScript runtime code to TypeScript across the OpenClaw ACP example image. While it touches multiple subsystems, it doesn't fit neatly into a specific functional component and is primarily a code quality/infrastructure improvement.

Severity Justification: This is a P3 (Low) severity contribution as it represents a refactoring and modernization effort with no reported bugs being fixed. The changes improve code maintainability and add CI coverage but don't address critical functionality, security issues, or data loss concerns.

Eligibility Notes: Tests are required and included: the PR adds extensive test files (acp-server.test.ts, acp-wrapper.test.ts, gateway-proxy tests, etc.) and a new CI workflow (example-image-tests.yml). This is a refactoring/modernization effort that warrants tests to ensure behavior is preserved during the JavaScript-to-TypeScript migration. No specific issue is referenced, but the PR is well-documented with clear description of the migration goals and improvements.


Analyzed by GitRank 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant