Skip to content

feat: SW-1825 stepper component#106

Open
vmujakovic-ts wants to merge 10 commits into
mainfrom
SW-1825-process-flow-component
Open

feat: SW-1825 stepper component#106
vmujakovic-ts wants to merge 10 commits into
mainfrom
SW-1825-process-flow-component

Conversation

@vmujakovic-ts
Copy link
Copy Markdown

@vmujakovic-ts vmujakovic-ts commented May 20, 2026 •
edited
Loading

Summary

Type of Change

  • Feature (new functionality)
  • Bug fix
  • Refactor
  • Documentation
  • Chore (build, CI, dependencies)
  • Breaking change

Checklist

  • yarn lint passes
  • yarn build passes
  • yarn test:all passes
  • Storybook stories added/updated
  • Code coverage remains the same or increased

Testing

Verification

  • Deploys to preview environment for manual verification
  • All CI/E2E checks pass

Screenshots

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ts-lib-ui-kit-storybook Ready Ready Preview, Comment Jun 2, 2026 8:12pm

Request Review

@vmujakovic-ts vmujakovic-ts changed the title intro component SW-1825 stepper component May 22, 2026
@vmujakovic-ts vmujakovic-ts marked this pull request as ready for review May 26, 2026 14:02
@vmujakovic-ts vmujakovic-ts requested review from a team as code owners May 26, 2026 14:02
@vmujakovic-ts vmujakovic-ts changed the title SW-1825 stepper component feat: SW-1825 stepper component May 26, 2026
@vmujakovic-ts vmujakovic-ts force-pushed the SW-1825-process-flow-component branch from 099d681 to 2488d4e Compare May 27, 2026 18:36
owilliams-tetrascience
owilliams-tetrascience requested changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@owilliams-tetrascience owilliams-tetrascience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀 I only had one small comment but overall great work

Comment thread src/components/composed/ProcessFlow/ProcessFlow.stories.tsx Outdated
}

const meta: Meta<typeof ProcessFlow> = {
title: "Patterns/ProcessFlow",
Copy link
Copy Markdown
Collaborator

@owilliams-tetrascience owilliams-tetrascience May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to "Design patterns". This was a recent change from UX

Copy link
Copy Markdown
Author

@vmujakovic-ts vmujakovic-ts May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abslutely!

Comment thread src/components/composed/ProcessFlow/ProcessFlow.test.tsx Outdated
);
});

it("does not call onStepSelect for disabled steps", () => {
Copy link
Copy Markdown
Collaborator

@owilliams-tetrascience owilliams-tetrascience May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinking generally most of these test should be covered in the storybook e2e tests? are any of these redundant?

Copy link
Copy Markdown
Author

@vmujakovic-ts vmujakovic-ts May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they are, but one of the actions in this repo was complaining and fialing.

54321jenn-ts
54321jenn-ts approved these changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@54321jenn-ts 54321jenn-ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's not a blocker but two points of feedback.

It'd be nice if you used our button group in your docs if possible #100

And for the left nav be sure to name it something human readable, like Process Flow or Stepper (not ProcessFlow)

blee-tetrascience
blee-tetrascience requested changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@blee-tetrascience blee-tetrascience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for test scope.

Comment thread src/components/composed/ProcessFlow/ProcessFlow.test.tsx Outdated
@@ -0,0 +1,406 @@
import { flushSync } from "react-dom";
Copy link
Copy Markdown
Collaborator

@blee-tetrascience blee-tetrascience May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a React component test suite in jsdom while the stories already exercise the rendering and interaction paths in a real browser. Repo guidance says component behavior should live in Storybook play tests and unit tests should cover pure logic. Could we remove the duplicated component assertions and keep only tests for helpers or constants that the stories cannot cover?

@claude
merge main and resolve conflict in src/index.ts
d8fafa8 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vmujakovic-ts vmujakovic-ts deployed to artifactory-prod June 2, 2026 20:10 — with GitHub Actions Active
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 93.87% (🎯 83%)
⬆️ +0.20%		 19923 / 21224
🟢 Statements 93.87% (🎯 83%)
⬆️ +0.20%		 19923 / 21224
🟢 Functions 93.02% (🎯 74%)
⬆️ +0.18%		 893 / 960
🟢 Branches 87.36% (🎯 81%)
⬆️ +0.52%		 3486 / 3990
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/composed/ProcessFlow/ProcessFlow.tsx 100% 100% 100% 100%
src/components/composed/ProcessFlow/ProcessFlow.utils.ts 100% 100% 100% 100%
Generated in workflow #718 for commit 6e429f6 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@54321jenn-ts 54321jenn-ts 54321jenn-ts approved these changes

@owilliams-tetrascience owilliams-tetrascience owilliams-tetrascience approved these changes

@blee-tetrascience blee-tetrascience Awaiting requested review from blee-tetrascience

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vmujakovic-ts @blee-tetrascience @54321jenn-ts @owilliams-tetrascience