Skip to content

fix: support form-associated custom elements in isLabelable #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mixelburg wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −2
Open

fix: support form-associated custom elements in isLabelable #1380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e553dd
fix: support form-associated custom elements in isLabelable
mixelburg May 13, 2026
a4fc3b0
fix: add eslint-disable for unsafe any calls in form-associated custo…
May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/label-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,29 @@ function getRealLabels(element: Element) {
}

function isLabelable(element: Element) {
return (
if (
/BUTTON|METER|OUTPUT|PROGRESS|SELECT|TEXTAREA/.test(element.tagName) ||
(element.tagName === 'INPUT' && element.getAttribute('type') !== 'hidden')
)
) {
return true
}

// Support form-associated custom elements
if (
element.tagName.includes('-') &&
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call
typeof (element as any).attachInternals === 'function'
) {
try {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call
const internals = (element as any).attachInternals()
return internals.formAssociated === true
} catch {
// Not a form-associated custom element or attachInternals not supported
}
}

return false
}

function getLabels(
Expand Down
Loading