-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/site msg backup migrations #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.9.x
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -66,7 +66,7 @@ | |||||||||||||||||||||
| "utopia-php/locale": "0.8.*", | ||||||||||||||||||||||
| "utopia-php/logger": "0.6.*", | ||||||||||||||||||||||
| "utopia-php/messaging": "0.20.*", | ||||||||||||||||||||||
| "utopia-php/migration": "1.6.*", | ||||||||||||||||||||||
| "utopia-php/migration": "dev-feat-message-migration", | ||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pinning a production dependency to a mutable dev branch makes builds non-reproducible and allows unreviewed upstream commits to be pulled; pin a tagged release or immutable commit reference instead.
Suggested change
Prompt for AI assistanceCopy the prompt below and paste it into ChatGPT, Claude, or any LLM: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pinning a production dependency to a branch-based dev version makes builds non-reproducible; depend on a tagged release or commit reference instead.
Suggested change
Prompt for AI assistanceCopy the prompt below and paste it into ChatGPT, Claude, or any LLM: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pinning a production dependency to a dev branch makes builds non-reproducible; use a tagged release or a commit reference instead.
Suggested change
Prompt for AI assistanceCopy the prompt below and paste it into ChatGPT, Claude, or any LLM: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pinning a production dependency to a mutable dev branch makes builds non-reproducible and can pull unreviewed code; pin a tagged release or immutable commit reference instead. Also reported at:
Suggested change
Prompt for AI assistanceCopy the prompt below and paste it into ChatGPT, Claude, or any LLM: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pinning a dependency to a VCS branch name makes builds non-reproducible and can unexpectedly pull breaking changes; pin a tagged release or commit hash instead.
Suggested change
Prompt for AI assistanceCopy the prompt below and paste it into ChatGPT, Claude, or any LLM: |
||||||||||||||||||||||
| "utopia-php/platform": "0.7.*", | ||||||||||||||||||||||
| "utopia-php/pools": "1.*", | ||||||||||||||||||||||
| "utopia-php/span": "1.1.*", | ||||||||||||||||||||||
|
|
@@ -109,5 +109,12 @@ | |||||||||||||||||||||
| "php-http/discovery": true, | ||||||||||||||||||||||
| "tbachert/spi": true | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "repositories": [ | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| "type": "vcs", | ||||||||||||||||||||||
| "url": "https://github.com/utopia-php/migration.git" | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| ], | ||||||||||||||||||||||
|
Comment on lines
+113
to
+118
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a direct VCS repository bypasses Packagist trust and can silently change the fetched package source; restrict this to an immutable reference or remove the custom repository for production builds.
Suggested change
Prompt for AI assistanceCopy the prompt below and paste it into ChatGPT, Claude, or any LLM:
Comment on lines
+113
to
+118
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a direct VCS repository for production dependencies bypasses normal release provenance controls; use a signed/tagged package release or pin an immutable commit reference. Suggested fix "repositories": [
{
"type": "vcs",
"url": "https://github.com/utopia-php/migration.git",
"no-api": true
}
],Prompt for AI assistanceCopy the prompt below and paste it into ChatGPT, Claude, or any LLM: |
||||||||||||||||||||||
| "prefer-stable": true | ||||||||||||||||||||||
|
Comment on lines
+113
to
+119
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a VCS repository that tracks a mutable GitHub branch allows unreviewed upstream changes into installs; pin the package to a tag or immutable commit hash. Suggested fix "repositories": [
{
"type": "vcs",
"url": "https://github.com/utopia-php/migration.git"
}
],
"prefer-stable": truePrompt for AI assistanceCopy the prompt below and paste it into ChatGPT, Claude, or any LLM: |
||||||||||||||||||||||
| } | ||||||||||||||||||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev-feat-message-migrationis an unstable branch reference — Composer resolves it to whateverHEADpoints to on that branch at install time. Any unreviewed commit pushed to that branch between now and a freshcomposer installwould silently change the exact code running in production. This also requires the"repositories"VCS override and forcesstability-flagsto20(dev), loosening the stability guarantees for the whole project. This should be replaced with a tagged, stable release once the upstream branch is merged.