fix(image): ship crew seeds so dynamic crew selection has a catalog - #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crews/*.yamlwas never copied into the ALM image. Verified on the running worker:Settings.crews_dirdefaults to the bare relative path"crews", resolved against WORKDIR/app.load_seed_crewsreturns{}for a directory that does not exist — it does not raise — so in production the seed catalog is empty and every dynamic crew pick resolves to nothing. Confirmed in-pod:select_crew(...)returnsNonefor backend, frontend and SRE intents alike, because there is nothing to rank.This is the remaining half of the silent no-op run. #285 made dynamic selection real and made a no-work run report itself honestly; it could not help while the thing being selected from was empty at runtime.
Change
Dockerfile:COPY crews/ /app/crews/, alongside the existingblueprints/andspecializations/copies.tests/unit/test_image_ships_runtime_catalogs.py: asserts every catalog directory named by aSettingsdefault both exists in the repo and is copied into the image WORKDIR. Verified it fails without the Dockerfile line.The test covers all three catalogs, not just crews, so the next directory added this way cannot regress the same silent-empty way.
Scope
Dockerfile.sreandDockerfile.runnerare deliberately untouched — neither ships blueprints or specializations either, and neither loads these catalogs. Thesre-*blueprints run on the ALM worker, which this fixes.