Fix snapshot and completion-wait races and stabilize native builds - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directory timestamps can stay unchanged during a file change, and an operation can complete while an asynchronous status read is still returning old state. Verify directory membership as well as metadata, and register completion listeners before reading state so these cases are detected reliably.
Also update Pages configure/upload/deploy actions to their maintained Node 24 releases: configure-pages v6, upload-pages-artifact v5, and deploy-pages v5.0.1.
Validation: backend follow-up 16/16 and operation-wait 3/3 each pass across ten repeated runs; integrity/recovery 20/20, MCP lifecycle 18/18, policy 16/16, native helper 9/9 and both Go suites pass. Real Electron operation waits pass repeatedly with the original 30-second timeout. Independent review verifies snapshot compatibility and cancellation. Fresh Windows checkout, repeated build, and workspace build produce identical native hashes; an isolated file-lock test verifies failed-publication cleanup. The final Windows package passes terminal (13), filesystem helper (8), MCP contract/binary, MCPB, real operation-wait and desktop-session checks. Windows CI passed on the final PR revision before merge.