chore(deps): react 18→19, ink 5→7 major#67
Open
terraboops wants to merge 5 commits into
Open
Conversation
Grouped major bump (ink 7 requires react 19): - react ^18.3.1 → ^19.2.7 - @types/react ^18.3.0 → ^19.2.17 - @testing-library/react ^14 → ^16.3.2 (+ @testing-library/dom ^10.4.1 peer) - ink ^5.1.0 → ^7.1.0 - Migrate interview App.tsx off ink-text-input (ink5-only, breaks ink7 reconciler) to the in-repo ChatInput replacement; drop the dependency. - Root overrides dedupe ink→7 / react→19 so ink-testing-library and the app share one instance (mintlify via nono-ts optional dep otherwise pins ink5/6).
# Conflicts: # package-lock.json # package.json # packages/autonav/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouped major upgrade (ink 7 requires react 19).
Changes
react^18.3.1 → ^19.2.7@types/react^18.3.0 → ^19.2.17@testing-library/react^14 → ^16.3.2 (added@testing-library/dom^10.4.1 — now a required peer in v16)ink^5.1.0 → ^7.1.0ink-text-input(ink5-only; its nested ink5/react18 broke ink7's reconciler → "Objects are not valid as a React child"). InterviewApp.tsxnow uses the in-repoChatInput(prop-compatible; already used by conversation UI and built for ink7/react19).overridesdedupeink→7 /react/react-dom→19 so the app andink-testing-libraryshare a single instance. Without it,mintlify/ink-spinner(pulled transitively by thenono-tsoptional dep) pin root ink to 5/6 and react to 18, splitting instances.@anthropic-ai/claude-agent-sdkstays at the lockfile-pinned 0.2.87 (newer 0.2.x peers zod ^4; project is on zod ^3 — pre-existing, unchanged). The lockfile was updated incrementally; plainnpm installreproduces it.Test
npm run typecheck(builds all workspaces) — pass (exit 0)npm test— pass (exit 0): @autonav/core 112 passed / 9 skipped; @autonav/communication-layer 45 passed / 13 skipped. Previously-failingtests/interview/interview-app.test.tsxnow passes.