Repository navigation
chore(docs): standardize package quality and renderer - #20
Conversation
…into development # Conflicts: # site/src/lib/catalog.ts # src/components/StaticWorkspace.tsx # src/components/navigation.tsx
Fix CommonJS ESLint globals and apply the reviewed repository updates. Validation: focused ESLint and git diff --check passed.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7dc2dda3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,19 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
The demo-build job in .github/workflows/check.yml still runs pnpm exec vite build --config config/vite.config.ts, but this commit deletes that configuration along with the demo sources. On every push and pull request, Vite will fail to load the specified config, causing the workflow to fail before the other checks can complete; remove the obsolete job or point it at an existing build.
Useful? React with 👍 / 👎.
| : undefined; | ||
| const sourceCssPlugins = sourceDevelopment | ||
| ? [ | ||
| requireFromPackage('postcss-import')(), |
There was a problem hiding this comment.
When the documented pnpm dev command runs from this repository, bin/docs.mjs sets DOCS_SOURCE_DEV=true, so Astro evaluates this call during config loading. This commit simultaneously removes postcss-import from package.json; after a clean pnpm install it exists only inside Tailwind's isolated dependency tree and cannot be resolved by requireFromPackage, so the development server exits with a module-resolution error before starting. Keep it as a direct dev dependency or avoid requiring it here.
Useful? React with 👍 / 👎.
| const { data, error: err } = await actions.read.doc.attachments({ paths }); | ||
| if (err || !data || Array.isArray(data)) { |
There was a problem hiding this comment.
When an existing DocsHostAdapter is upgraded, its read.doc.attachments implementation may still support the previously used { path } request and return an attachment array. This dialog now unconditionally sends { paths } and explicitly discards array responses, so those hosts show no attachments in the page/group management dialog even though individual attachment reads still work elsewhere. Retain the per-path calls as a fallback, or introduce the batch operation without removing compatibility with the existing contract.
Useful? React with 👍 / 👎.
Summary
Push the current repository snapshot for review.
Validation