Make codense compatible with tern-closure plugin - #406
Closed
MetaMemoryT wants to merge 11 commits into
Closed
Conversation
This reverts commit 293823c.
Imports and exports union type information from condense json files.
tern-closure requires that doc_comment is NOT loaded. When creating condense output their was previously no way to disable it. Now their is a command line option to disable loading doc_comment.
The previous code was redundant: type.doc || (something && type.doc ) I think it should be what I changed it to. When exporting condense output from tern-closure, I needed to be actual.doc, as thats where tern-closure adds the comments.
Member
|
Due to the fact that the commit list isn't exactly clean, and your other pull request is also in there, I'm having a hard time seeing what this is doing. Let's look at it again after we've resolved what to do about #405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.