feat: set MPP client ID for on-chain attribution#418
Merged
Conversation
Contributor
✅ Changelog found on PR. |
All TempoProvider instances now call .with_client_id("tempo-cli") so
charge transactions carry a non-zero client fingerprint in the
attribution memo, enabling on-chain tracking of CLI-originated payments.
Co-authored-by: Brendan Ryan <1572504+brendanjryan@users.noreply.github.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d69c7-d457-73dc-a808-fec1a25678f5
Changes CLIENT_ID from "tempo-cli" to "tempo-wallet" and adds an
integration test that verifies the keccak256("tempo-wallet") fingerprint
appears in the payment credential sent during the charge flow.
Also adds Authorization header capture to MockServer for test inspection.
Co-authored-by: Brendan Ryan <1572504+brendanjryan@users.noreply.github.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d69c7-d457-73dc-a808-fec1a25678f5
Slokh
force-pushed
the
brendan/add-mpp-client-id
branch
from
5f2c7aa to
d8e2e55
Compare
Slokh
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
TempoProviderinstances now call.with_client_id("tempo-cli")so charge transactions carry a non-zero client fingerprint in the attribution memo (bytes 15–24), enabling on-chain tracking of CLI-originated payments.Changes
CLIENT_IDconstant ("tempo-cli") incharge.rs.with_client_id(CLIENT_ID)to all 4TempoProvider::newcall sites (initial charge, both provisioning retries, and zero-amount proof)Testing
make check— all 477 tests pass, clippy/fmt/doc/typos clean.Prompted by: brendan