Skip to content

Simplify SKILL.md version updates - #8

Merged
patbeqo merged 4 commits into
mainfrom
fix/simplify-skill-version-bump
Sep 4, 2026
Merged

patbeqo merged 4 commits into
mainfrom
fix/simplify-skill-version-bump

Conversation

@patbeqo

@patbeqo patbeqo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Why

This draft PR corrects the agent-authored patch from #7. The previous fix worked in production, but it introduced custom YAML parsing that is more complicated than necessary.

Every SKILL.md must have exactly one canonical version: ... field in its frontmatter. This change uses python-frontmatter for frontmatter detection and YAML validation, then directly replaces the parsed version text so no unrelated formatting changes.

Changes

  • use python-frontmatter for frontmatter detection and metadata validation
  • replace the parsed canonical version text directly without serializing the document
  • preserve existing line endings, body content, and final-newline state
  • retain rejection tests for missing and multiple version fields
  • use explicit golden expected values in formatting regression tests

Tests

  • python .github/scripts/tests/test_bump_version.py -v
  • python .github/scripts/tests/test_validate_rollback_version.py -v

@patbeqo
patbeqo marked this pull request as ready for review September 4, 2026 16:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T17:02:42.920147Z 7c1dcaf New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e98efd22a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/scripts/bump_version.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c1dcafe71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/scripts/bump_version.py
@patbeqo
patbeqo merged commit 818a537 into main Sep 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant