feat(client): allow usage of protox instead of system protoc - #1590
Merged
Conversation
chris-olszewski
commented
Sep 4, 2026
|
|
||
| [build-dependencies] | ||
| prost = { workspace = true } | ||
| prost-types = "0.14" |
Member
Author
There was a problem hiding this comment.
Note: our workspace aliases prost-types to prost-wkt-types. I think this dep was a mistake as it pulls in an unused and different prost-types crate. It was causing issues when we were trying to enable vendored-protox as the "real" prost-types crate doesn't have this feature.
Sushisource
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add
vendored-protoxfeature to the protos crate and thread it through up to the client crate. Enabling the feature will switch the proto build to useprotoxinstead of trying to find a system protoc install.Why?
Useful for avoiding setting up a protoc to use the Rust SDK.
Checklist
Closes Support vendored/pure-Rust protoc for temporalio-protos (like prost-wkt-types already does) #1589
How was this tested:
Verified locally, added a CI job that verifies we can build without a protoc.
Any docs updates needed?
Added README updates to the appropriate crates.