Downgrade minimum protobuf version needed to 3.25#213
Conversation
|
What can go wrong with this in the future? Does that mean we will need to coordinate with coinbase's temporal-ruby's team whenever that dependency needs to be updated? And users will need to ensure they always have compatible versions of the two SDKs? We probably can't do much about this, but that might need to be clarified in docs… |
No, we don't need to coordinate, this PR is just saying the minmum protobuf version we work with, we will work with all later if they upgrade. But coinbase Ruby SDK has not changed in this area in a long while, and we have a sample that would break if either side was no longer interoperable. Really this specific issue is just because of a mistake I made setting the minimum |
What was changed
Downgraded minimum protobuf version needed to 3.25. This is needed to interoperate with https://github.com/coinbase/temporal-ruby (along with coinbase/temporal-ruby#335 from that side)