Repository navigation
Propagate Nexus serialization context to workflow updates - #2045
Open
JoshuaFrenchwood wants to merge 1 commit into
Open
JoshuaFrenchwood wants to merge 1 commit into
JoshuaFrenchwood wants to merge 1 commit into
Conversation
Merged
JoshuaFrenchwood
force-pushed
the
nexus-serialization-context-workflow-update
branch
3 times, most recently
from
October 29, 2026 20:25
c870677 to
f10c76b
Compare
tconley1428
force-pushed
the
nexus-serialization-context-workflow-update
branch
from
October 29, 2026 20:28
f10c76b to
6eccfc8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Nexus operation handlers now propagate their
NexusSerializationContextto the workflow updates they send.DoUpdate, at both the converter and codec layers. Updates have no sequence number, so the codec looks up the context by protocol instance ID. The context is kept until the activation that finished the update has been encoded. Replay gets the same context, since Core buildsDoUpdatefrom history.WorkflowUpdateHandle.result()decodes with the context returned on the update and poll responses, so a handle obtained withget_update_handledecodes correctly.Why?
A Nexus handler returns the result and failure of the update it sends to the Nexus caller. The caller decodes them with the operation's
NexusSerializationContext, so a codec keyed on the context couldn't decode them when they were encoded with the workflow context.Checklist
Closes
How was this tested:
test_nexus_sent_update_uses_nexus_context[result|failure|rejection]runs on the dev server with the strict Nexus marker codec. It checks:Replayersucceeds.