Skip to content

[SDK Sentinel] Stabilize unfinished-handler cancellation test #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdk-sentinel-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SDK Sentinel] Stabilize unfinished-handler cancellation test #1824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6969,9 +6969,6 @@ async def _run_workflow_and_get_warning(self) -> bool:
id=workflow_id,
task_queue=task_queue,
)
if self.workflow_termination_type == "-cancellation-":
await handle.cancel()

if self.handler_type == "-update-":
update_method = (
"__does_not_exist__"
Expand Down Expand Up @@ -7000,6 +6997,9 @@ async def _run_workflow_and_get_warning(self) -> bool:
)
await handle.signal(signal_method) # type: ignore

if self.workflow_termination_type == "-cancellation-":
await handle.cancel()

async with new_worker(
self.client,
UnfinishedHandlersOnWorkflowTerminationWorkflow,
Expand Down