Support new API fields in ActivityHandle.describe - #1782
Merged
Conversation
tconley1428
reviewed
Aug 25, 2026
tconley1428
reviewed
Aug 25, 2026
maciejdudko
force-pushed
the
saa-describe-payloads
branch
from
September 1, 2026 18:03
10cfb2a to
794894e
Compare
maciejdudko
force-pushed
the
saa-describe-payloads
branch
from
September 1, 2026 22:09
794894e to
7cfb7de
Compare
tconley1428
reviewed
Sep 3, 2026
GregoryTravis
added a commit
that referenced
this pull request
Sep 3, 2026
Drops the four include_* opt-ins, the eager payload members on ActivityExecutionDescription, and the tests that exercise them, so that #1782 owns the describe surface outright. Operator commands, the ActivityOptionsKey/Update API and ActivityExecutionOptions are untouched. Heartbeat-detail observation is impossible until #1782 lands: the server withholds those payloads without the opt-in, so the three *_preserves_heartbeat tests are removed here and should return afterwards using 1782's await desc.heartbeat_details().
tconley1428
reviewed
Sep 8, 2026
tconley1428
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
@dataclassconfiguration for ActivityExecution and ActivityExecutionDescriptionWhy?
Implements newly added API features and removes parts that were not meant to be exposed.
Checklist
Updated
tests.test_activity.TestDescribe