Skip to content

Support new API fields in ActivityHandle.describe - #1782

Merged
tconley1428 merged 7 commits into
temporalio:mainfrom
maciejdudko:saa-describe-payloads
Sep 9, 2026
Merged

Support new API fields in ActivityHandle.describe#1782
tconley1428 merged 7 commits into
temporalio:mainfrom
maciejdudko:saa-describe-payloads

Conversation

@maciejdudko

Copy link
Copy Markdown
Contributor

What was changed

  • Added options for retrieving optional payloads in ActivityHandle.describe()
  • Removed long polling from ActivityHandle.describe()
  • Added late-deserializing methods to ActivityExecutionDescription for payload-bearing properties
  • Refactored ActivityExecutionDescription creation, added missing properties and removed properties that don't exist or shouldn't be exposed
  • Adjusted @dataclass configuration for ActivityExecution and ActivityExecutionDescription

Why?

Implements newly added API features and removes parts that were not meant to be exposed.

Checklist

  1. How was this tested:

Updated tests.test_activity.TestDescribe

@maciejdudko
maciejdudko requested a review from a team as a code owner August 24, 2026 22:33
Comment thread temporalio/client/_activity.py Outdated
Comment thread temporalio/client/_impl.py Outdated
@tconley1428 tconley1428 self-assigned this Aug 25, 2026
@maciejdudko
maciejdudko force-pushed the saa-describe-payloads branch from 10cfb2a to 794894e Compare September 1, 2026 18:03
@maciejdudko
maciejdudko force-pushed the saa-describe-payloads branch from 794894e to 7cfb7de Compare September 1, 2026 22:09
Comment thread temporalio/client/_activity.py
GregoryTravis added a commit that referenced this pull request Sep 3, 2026
Drops the four include_* opt-ins, the eager payload members on
ActivityExecutionDescription, and the tests that exercise them, so that
#1782 owns the describe surface outright. Operator commands, the
ActivityOptionsKey/Update API and ActivityExecutionOptions are untouched.

Heartbeat-detail observation is impossible until #1782 lands: the server
withholds those payloads without the opt-in, so the three
*_preserves_heartbeat tests are removed here and should return afterwards
using 1782's await desc.heartbeat_details().
Comment thread temporalio/client/_activity.py
@tconley1428
tconley1428 merged commit aecdc24 into temporalio:main Sep 9, 2026
32 of 34 checks passed
@maciejdudko
maciejdudko deleted the saa-describe-payloads branch September 9, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants