Report the build and pod name each proxy process is running - #273
Draft
liam-lowe wants to merge 1 commit into
Draft
Report the build and pod name each proxy process is running#273liam-lowe wants to merge 1 commit into
liam-lowe wants to merge 1 commit into
Conversation
liam-lowe
marked this pull request as draft
September 2, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
build_infogauge, always 1, labelled with the version the running binary was stamped with.collectors.NewBuildInfoCollectorreports the Go module version. That is not the same thing. This reports the-X main.Versionstamp. A half-finished rollout is therefore visible as two series rather than one.Reporting it needs the process to know who it is. This therefore also adds
Identity: aVersionand aMemberID, supplied toNewProxyrather than read from config. A value in the shared config file would be identical on every replica. That is the one thing an identity cannot be.DefaultIdentityreads$POD_NAMEfirst. A Kubernetes deployment can therefore be explicit. The fallback is the hostname. Inside a pod that is the pod name. The chart suppliesPOD_NAMEthrough the downward API.NewProxygains a third parameter. Every caller is updated.app/app.gosuppliesDefaultIdentity. The test callers supply a literal.Testing
make lint: 0 issues.go test -race ./...: every package passes.helm unittest s2s-proxy/: passes.make helm-exampleshows no drift.build_infois set on a path the existingNewProxytests already exercise.DefaultIdentityreads only the environment. Both are worth covering when a consumer ofMemberIDarrives.