docs(config): say what cache_size zero actually does - #811
Closed
xepozz wants to merge 1 commit into
Closed
Conversation
InitDefaults replaces a zero cache_size with 10000, so zero cannot be used to turn the sticky cache off - only a negative value does that.
rustatian
reviewed
Aug 23, 2026
| "minLength": 1 | ||
| }, | ||
| "cache_size": { | ||
| "description": "Sticky cache size. Sticky workflow execution is the affinity between workflow tasks of a specific workflow execution to a specific worker. The benefit of sticky execution is that the workflow does not have to reconstruct state by replaying history from the beginning. The cache is shared between workers running within same process. This must be called before any worker is started. If not called, the default size of 10K (which may change) will be used.", |
Collaborator
There was a problem hiding this comment.
Why was the comment with This must be .. removed?
Collaborator
Author
There was a problem hiding this comment.
So if you call config parameters I'll back it then, usually I don't
Collaborator
There was a problem hiding this comment.
Not sure I get you; could you please rephrase?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for This PR
[Author TODO: add issue # or explain reasoning.]Description of Changes
InitDefaults replaces a zero cache_size with 10000, so zero cannot be used to turn the sticky cache off - only a negative value does that.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.