Preserve Nexus operation payloads with RawValue - #483
Open
stephanos wants to merge 17 commits into
Open
Conversation
stephanos
marked this pull request as draft
September 10, 2026 15:31
stephanos
force-pushed
the
nexus-raw-value-results
branch
from
September 10, 2026 18:47
2018c33 to
28b5e16
Compare
stephanos
added this pull request to stack #485
September 10, 2026 18:47
stephanos
force-pushed
the
nexus-raw-value-results
branch
from
September 10, 2026 19:47
3bc4e4d to
7c79583
Compare
stephanos
commented
Sep 10, 2026
| NexusOperationCompleted | ||
| NexusOperationCompleted {"links":[{"workflowEvent":{"workflowId":"nexus-sync-update-target","requestIdRef":{"eventType":"EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_ACCEPTED"}}}]}`), | ||
| expectedUnsupportedErrs: nexusWorkflowActionUnsupportedSDKs, | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
This is the main regression we're fixing.
The other ones I added here are also valuable, ofc. They increase confidence in the overall change here.
stephanos
marked this pull request as ready for review
September 10, 2026 19:56
THardy98
approved these changes
Sep 11, 2026
THardy98
left a comment
THardy98
left a comment
Contributor
There was a problem hiding this comment.
thanks for doing this across all workers!
Not blocking, but I believe there's an identity converter in the code somewhere (i.e payloadA -> identity converter just returns ... -> payloadA) that should no longer be necessary.
If so, would you mind filing an issue to remove it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fix establishes one consistent rule: kitchen-sink Nexus results are opaque payloads and cross every result boundary as
RawValue.Why
The kitchen-sink APIs use
common.Payloadas an already-encoded, opaque value. Passing that value through the SDK as an ordinary*common.Payloadcauses the data converter to serialize it again, ie adding another payload wrapper/envelope.Nexus exposed this because synchronous and asynchronous completions take different routes:
Using
RawValueonly in the Nexus caller was insufficient. It stopped decoding the outer envelope, but producers such asKitchenSinkWorkflowetc were still creating that envelope.RawValueis the SDK abstraction specifically intended for forwarding an already-encoded payload, so this avoids custom converter special cases and makes results independent of whether the operation completed synchronously or asynchronously.