Repository navigation
Made the stream-service create return the stream itself. - #298
Merged
Merged
Conversation
The stream resource takes created and status beside its ref, and return binding fills them from the response. The ref stays an identity.
moetemp
force-pushed
the
moe/up/create-stream-returns-stream
branch
from
October 26, 2026 23:28
c0d4047 to
87b032f
Compare
tconley1428
approved these changes
Oct 26, 2026
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR makes the
stream-servicesample'screate-streamreturn thestreamresource, not a record that holds it.createdandstatusbeside itsstream-ref, and return binding fills them fromCreateStreamResponse.stream-refstays an identity, so the requests of the resource methods don't carry the status.Why?
A create should give the caller the stream to use. The facts of the create belong to the handle that it returns, and the ref is what every later call sends.
How did you test it?
The
stream-servicegoldens for Python, TypeScript and .NET. A .NET check now builds a stream from a ref with no facts.cargo validatepasses.