Bump protobufjs pnpm override 7.5.1 → ^8.7.1 - #892
Merged
Conversation
@temporalio/common@1.23.0 requires protobufjs/ext/protojson which was added in protobufjs 7.5.2. The pnpm override pinning 7.5.1 causes "Cannot find module 'protobufjs/ext/protojson'" errors in all TypeScript kitchensink tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@temporalio/common@1.23.0 declares protobufjs@^8.7.1 as a dependency. The ext/protojson module was added in protobufjs 8.6.0, so bumping to 7.5.2 would not have fixed the issue. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rkannan82
changed the title
The pin exists in two places — the pnpm override in sdkbuild (for external consumers like omes) and the root package.json (for the features repo's own TS tests). Both need ^8.7.1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
I also need this fix 👀 |
THardy98
approved these changes
Sep 8, 2026
rkannan82
added a commit
to temporalio/omes
that referenced
this pull request
Sep 8, 2026
Picks up temporalio/features#892 which bumps the protobufjs pnpm override from 7.5.1 to ^8.7.1, fixing TS kitchensink CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rkannan82
added a commit
to temporalio/omes
that referenced
this pull request
Sep 8, 2026
Picks up temporalio/features#892 which bumps the protobufjs pnpm override from 7.5.1 to ^8.7.1, fixing TS kitchensink CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rkannan82
added a commit
to temporalio/omes
that referenced
this pull request
Sep 8, 2026
Picks up temporalio/features#892 which bumps the protobufjs pnpm override from 7.5.1 to ^8.7.1, fixing TS kitchensink CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rkannan82
added a commit
to temporalio/omes
that referenced
this pull request
Sep 8, 2026
Picks up temporalio/features#892 which bumps the protobufjs pnpm override from 7.5.1 to ^8.7.1, fixing TS kitchensink CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rkannan82
added a commit
to temporalio/omes
that referenced
this pull request
Sep 8, 2026
Picks up temporalio/features#892 which bumps the protobufjs pnpm override from 7.5.1 to ^8.7.1, fixing TS kitchensink CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump
protobufjsfrom7.5.1to^8.7.1in both the rootpackage.jsonand the pnpm override insdkbuild/typescript.go.Why
@temporalio/common@1.23.0requiresprotobufjs@^8.7.1. The 7.5.1 pin (added as a temporary workaround in #625, underlying issue since fixed in temporalio/sdk-typescript#1717) blocks 8.x resolution, breaking all TS kitchensink tests in omes withCannot find module 'protobufjs/ext/protojson'.How did you test it?
Confirmed
@temporalio/common@1.23.0declaresprotobufjs@^8.7.1vianpm view. Confirmedext/protojsonwas added in protobufjs 8.x. Will verify omes CI passes after this merges and omes bumps its features dep.