Repository navigation
Raise CancelledError when a Claude Agent SDK Activity is cancelled - #317
Merged
Merged
Conversation
The Claude Agent SDK cancels its read task on close and expects asyncio.CancelledError. A cancelled read Activity raised ActivityError instead, which the SDK logged as "Fatal error in message reader". Fixes #316
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
patbeqo
enabled auto-merge (squash)
October 30, 2026 21:44
brianstrauch
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #316.
When a client closes while its read Activity is running, the Worker logs
Fatal error in message reader: Activity cancelled. Nothing fails, but it reads like a crash.The Claude Agent SDK cancels its read task on close and expects
asyncio.CancelledError.TemporalTransportraised the cancelledActivityErrorinstead. It now raisesCancelledError, with theActivityErroras its cause. Temporal treats both as a cancellation, so a cancelled Workflow still ends as Canceled.Testing
make lintandmake testpass (103 tests).agent_chatsample from Add Claude Agent SDK samples samples-python#403 no longer logs the error on Continue-As-New or at the end of the chat.