Repository navigation
test(sdk-tanstack-ai): cover the onConfig phase guard - #162
Merged
aikins01 merged 1 commit intoNov 3, 2026
Merged
Conversation
Supported engines call onConfig after onStart only before a model call, so no engine run reaches the guard that skips the other phases. Calling it directly for each of those phases now shows that none opens an iteration span. Removing the guard fails every case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #83. Supported engines call
onConfigafteronStartonly before a model call, so no engine run reaches the guard that skips the other phases. The new test callsonConfigdirectly for each of those phases afteronStartand checks that none opens an iteration span. Removing the guard fails all five cases; on main, every tanstack-ai test passes without it.