Repository navigation
fix(sdk): find the comment of the action on the old pages of a long pull request - #157
Merged
Merged
Conversation
…ull request The action read page 1 and then the 9 newest pages of comments, thus on a pull request that grew past 1,000 comments it missed its comment from an early push and added a new one. It now reads the 5 oldest and the 5 newest pages, each page once. The READMEs now say that in the action a failed experiment fails the job also with ci: false.
This was referenced Oct 31, 2026
Merged
aikins01
added a commit
that referenced
this pull request
Oct 31, 2026
Since the core SDKs record exception text only when both capture flags are on (#88), the root, Bedrock, opencode, omp, and pi READMEs no longer say that exception messages are recorded regardless of them. The root README names the error messages that TanStack AI records. Values are sent whole by default (#148), so tool definitions in Google GenAI, Bedrock agent traces, and LiteLLM metadata are cut only at a maxAttributeLength that is set, not at 65,536 characters. The Python READMEs keep the old cap for telemetry-dev 0.3.2 and earlier, which their dependency floors still allow. The Python README says that a call in a child forked during a prompt fetch looks at the cache again and starts a new fetch if it must (#159), names the timeout of create_telemetry_span_exporter, and drops the note about integrations that run on a core without record_output_chunk: every integration requires telemetry-dev 0.3.0 or later, which has it. The CLI README describes the trace summary and the suggested next commands (#128). The experiment action README names the failed runs in the comment, the pages it reads to find its comment (#157), and an empty github-token. The root README lists prompts, experiments, and scores, and the CI check of the packed npm exports (#155, #160). The opencode plugin file example depends on ^0.2.2, not ^0.1.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #154 from its review. On a pull request with more than 1,000 comments, #154 read page 1 and then the 9 newest pages, so a comment from an early push on page 2 to 4 was missed and the action added a new one, which 1.0.0 did not do. The action now reads the 5 oldest pages and then the 5 newest, each page once. On 11 or more pages, a comment on page 6 through the last page minus 5 is still missed; any fixed number of pages leaves such a gap.
#154 also makes a failed experiment fail the job when the script exits with 0, and that includes a script that runs the experiment with
ci: false, which was green with 1.0.0. The action cannot tell that case apart, because the result line that the SDKs write has no CI mode. This PR says it in the action README and in the CI mode sections of both SDK READMEs. Whether the next action release should instead be a major version (fix!:, per RELEASING.md), or the SDKs should write the CI mode so that the action can skip those results, is still open.Tests:
vp test run --changedinpackages/sdk(tests/experiment-action.test.ts) andvp check.Refs telemetry-dev/telemetry.dev#619