Repository navigation
fix(data-grid): wait for nested shadow components before measuring - #2554
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the stated scope and provides focused regression coverage without introducing unresolved issues.
0 open findings
What changed in this PR
Ensures DataGrid auto-width measurement includes content hydrated within nested shadow roots.
Changes:
- Recursively waits for light- and shadow-DOM descendants before measurement.
- Extends regression coverage for light DOM and two nested shadow roots.
| File | Description |
|---|---|
data-grid.tsx |
Adds recursive component readiness traversal. |
data-grid.spec.ts |
Tests delayed hydration across light and nested shadow DOM. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the remaining data-grid readiness issue from #2552. Wait for each component before traversing its light-DOM and shadow-DOM children, so children created during hydration are included before auto-width measurement.
Extend the existing regression test with a delayed component inside two shadow roots. Keep the existing light-DOM case and stale fields/rows guard. No public API change.
Evidence
auto, received12before hydration completes.120.Merge Danger
Door: two-way
Blast Radius: data-grid
Only automatic column measurement timing changes. Existing visual baselines are unchanged. A descendant that never resolves
componentOnReady()will continue to delay measurement, as a light-DOM descendant already does.