Skip to content

Update Stencil and React output target dependencies - #2551

Merged
amir-ba merged 2 commits into
telekom:mainfrom
amir-ba:chore/update-stencil-dependencies
Oct 6, 2026
Merged

amir-ba merged 2 commits into
telekom:mainfrom
amir-ba:chore/update-stencil-dependencies

Conversation

@amir-ba

@amir-ba amir-ba commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Upgrade @stencil/core to 4.45.2.
  • Upgrade @stencil/react-output-target to 1.6.2 in both component workspaces.
  • Keep @stencil-community/postcss at 2.2.0, already the latest release.
  • Refresh the Yarn lockfile.

Validation

  • Components build passed with Stencil 4.45.2.
  • React wrapper build and type check completed; Rollup reported non-blocking TypeScript warnings for generated server component declarations.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 22:30
@amir-ba
amir-ba requested a review from maomaoZH as a code owner October 6, 2026 22:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The dependency declarations and refreshed lockfile are consistent with the stated upgrades and validation.

Review effort: Balanced
Findings: None

What changed in this PR

Updates Stencil tooling and React wrapper generation dependencies across the component workspaces.

Changes:

  • Upgrades Stencil Core to 4.45.2.
  • Upgrades the React output target to 1.6.2.
  • Refreshes associated transitive dependencies in the Yarn lockfile.
File Description
packages/​components/​package.json Updates Stencil build dependencies.
packages/​components-react/​package.json Updates the React output target runtime dependency.
yarn.lock Locks updated direct and transitive dependencies.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@amir-ba

amir-ba commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed locally and pushed eafcac7.

Changes:

  • Refresh spec snapshots for correct label for attributes and reflected boolean serialization in Stencil 4.45.2.
  • Transform class properties before the existing class transform in Storybook Babel loaders.
  • Commit regenerated component documentation and React server wrapper output.

Local validation with Node 24:

  • Specs: 358 tests and 168 snapshots passed.
  • E2E: 78 tests across 35 suites passed.
  • Component build, React build, React props type check, and Storybook build passed.
  • Visual tests with pinned Chromium 108.0.5342.0: 392 tests and 464 image snapshots passed without baseline changes. Existing skips: 9 suites / 113 tests.
  • Formatting, lint, commitlint, and repeat-build generated-file cleanliness passed.
  • Tracked-file hashes matched between the isolated candidate and local Linux validation checkout.

Builds still report existing non-blocking dependency and generated server declaration warnings.

@amir-ba
amir-ba merged commit e251dd6 into telekom:main Oct 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants