Skip to content

fix(ci): separate collected resources with YAML document markers#2798

Open
zakisk wants to merge 2 commits into
tektoncd:mainfrom
zakisk:add-divider-in-upload-job
Open

fix(ci): separate collected resources with YAML document markers#2798
zakisk wants to merge 2 commits into
tektoncd:mainfrom
zakisk:add-divider-in-upload-job

Conversation

@zakisk

@zakisk zakisk commented Jun 24, 2026

Copy link
Copy Markdown
Member

📝 Description of the Change

Use per-resource kubectl get with --- separators when collecting pipelineruns, repositories, and configmaps in CI log artifacts so each resource is a distinct YAML document.

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

Use per-resource kubectl get with --- separators when collecting
pipelineruns, repositories, and configmaps in CI log artifacts so
each resource is a distinct YAML document.

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the log collection script hack/gh-workflow-ci.sh to fetch individual Kubernetes resources (pipelineruns, repositories, and configmaps) in loops and write them to YAML files. The review feedback highlights a critical issue: because set -e and set -o pipefail are active, any failure in kubectl get (such as a resource being deleted during collection) will cause the entire script to abort prematurely. It is recommended to handle potential errors gracefully by checking if the resource exists and redirecting stderr.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread hack/gh-workflow-ci.sh
Comment thread hack/gh-workflow-ci.sh
this allows e2e workflow run on any changes in hack/
directory as there are all the script used across
workflow file.

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
@zakisk zakisk force-pushed the add-divider-in-upload-job branch from aae0520 to 0a37e70 Compare June 24, 2026 11:56
@zakisk zakisk requested a review from chmouel June 25, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant