Repository navigation
Conversation
* **Severity:** MEDIUM * **Vulnerability:** The HTTP server lacked a default `WriteTimeout` (or `WriteDeadline`) for responses that had no configured delay. * **Impact:** A malicious client could perform a Slowloris-style slow-read attack, keeping connections open indefinitely and causing resource exhaustion. * **Fix:** Moved the `SetWriteDeadline` call outside the conditional check for `resp.Delay > 0` in `internal/server/server.go`. This ensures all responses have a default 30-second write deadline (plus any configured delay) unconditionally. * **Verification:** Ran test suite (`make check`) to ensure no regressions were introduced. Co-authored-by: tejjasdev <213147578+tejjasdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes a missing default
WriteTimeoutconfiguration in the portbell server.Previously,
SetWriteDeadlinewas only set when a delay was configured on the response. Moving this outside of the condition ensures all connections have a sensible timeout applied, preventing potential resource exhaustion from slow-reading clients.PR created automatically by Jules for task 6541333343255621311 started by @tejjasdev