Skip to content

Reference output.txt in results.yaml when custom results are missing#4888

Merged
psss merged 2 commits into
mainfrom
show-output-txt-on-timeout
May 18, 2026
Merged

Reference output.txt in results.yaml when custom results are missing#4888
psss merged 2 commits into
mainfrom
show-output-txt-on-timeout

Conversation

@bajertom
Copy link
Copy Markdown
Contributor

I've used @happz solution and added a simple test scenario.

Pull Request Checklist

  • implement the feature
  • extend the test coverage

Fixes #4753

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request ensures that output.txt is included in the logs when custom results are missing or a test times out. A typo was identified in the test metadata summary where result.yaml should be corrected to results.yaml.

Comment thread tests/execute/result/custom/test.fmf Outdated
@bajertom bajertom force-pushed the show-output-txt-on-timeout branch from ae47abb to 24abd4c Compare May 14, 2026 21:31
@github-project-automation github-project-automation Bot moved this to backlog in planning May 15, 2026
@bajertom bajertom moved this from backlog to review in planning May 15, 2026
@bajertom bajertom added bug Something isn't working step | execute Stuff related to the execute step labels May 15, 2026
@psss psss changed the title Reference output.txt in results.yaml even after time out Reference output.txt in results.yaml when custom results are missing May 15, 2026
Comment thread tests/execute/result/custom/test.fmf Outdated
@happz happz assigned happz and unassigned happz May 17, 2026
@bajertom bajertom added the ci | full test Pull request is ready for the full test execution label May 18, 2026
@psss psss added this to the 1.74 milestone May 18, 2026
@psss
Copy link
Copy Markdown
Member

psss commented May 18, 2026

/packit test

@psss psss moved this from review to merge in planning May 18, 2026
@psss psss force-pushed the show-output-txt-on-timeout branch from f9690e0 to e248529 Compare May 18, 2026 13:44
@psss psss merged commit 6a9499c into main May 18, 2026
34 checks passed
@psss psss deleted the show-output-txt-on-timeout branch May 18, 2026 15:13
@github-project-automation github-project-automation Bot moved this from merge to done in planning May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci | full test Pull request is ready for the full test execution step | execute Stuff related to the execute step

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

Surface output.txt in results when custom results file is missing (e.g. after timeout)

4 participants