Skip to content

Drop setuptools requirement#4884

Open
LecrisUT wants to merge 1 commit into
teemtee:mainfrom
LecrisUT:fix/setuptools-82
Open

Drop setuptools requirement#4884
LecrisUT wants to merge 1 commit into
teemtee:mainfrom
LecrisUT:fix/setuptools-82

Conversation

@LecrisUT
Copy link
Copy Markdown
Member

Setuptools 82 is now in rawhide

Associated issue has been resolved, but can't tell in which version that was.

Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT LecrisUT added packaging Changes related to the rpm packaging plugin | mrack The beaker provision plugin ci | full test Pull request is ready for the full test execution labels May 13, 2026
@github-project-automation github-project-automation Bot moved this to backlog in planning May 13, 2026
@LecrisUT LecrisUT moved this from backlog to review in planning May 13, 2026
@LecrisUT LecrisUT added the review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-) label May 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'setuptools<81' constraint from the project dependencies in 'pyproject.toml' and 'uv.lock'. The reviewer suggests updating 'mrack' to a version that resolves the 'pkg_resources' deprecation issue instead of pinning 'setuptools', as the current removal may cause regressions on systems with 'setuptools >= 81'.

I am having trouble creating individual review comments. Click here to see my feedback.

pyproject.toml (75-77)

medium

Update mrack to a version fixing the pkg_resources issue. Drop the setuptools constraint or include a minimum version bump for the consumer to avoid regressions on systems with setuptools >= 81.

References
  1. Use direct imperatives. (link)

@happz
Copy link
Copy Markdown
Contributor

happz commented May 14, 2026

Interestingly, it's the rawhide testing that fails.

@LecrisUT
Copy link
Copy Markdown
Member Author

Interestingly, it's the rawhide testing that fails.

I suspect the pkg_resources issue is not properly resolved :/

@LecrisUT
Copy link
Copy Markdown
Member Author

Ok, the relevant patch did not land in rawhide, it will be backported hopefully beaker-project/beaker#232 (comment)

@LecrisUT
Copy link
Copy Markdown
Member Author

Ok, so there exists a compat package python-setuptools80 that we are pulling in until upstream patch lands. so this is for now blocked

@LecrisUT LecrisUT added the status | blocked The merging of PR is blocked on some other issue label May 14, 2026
@psss psss moved this from review to backlog in planning May 14, 2026
@LecrisUT LecrisUT moved this from backlog to review in planning May 14, 2026
@LecrisUT LecrisUT removed the status | blocked The merging of PR is blocked on some other issue label May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution packaging Changes related to the rpm packaging plugin | mrack The beaker provision plugin review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-)

Projects

Status: review

Development

Successfully merging this pull request may close these issues.

4 participants