Extends suppored input formats for hardware key#4877
Open
happz wants to merge 3 commits into
Open
Conversation
happz
added
area | hardware
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the hardware key in provision plugins to support JSON/YAML file references and direct JSON blobs, while removing support for key=value CLI snippets. A new utility function _normalize_structured_blob handles these inputs, including URL fetching. Feedback suggests using is_url() for robust URL detection and specifying utf-8 encoding when reading files.
* CLI option now accepts JSON blob, and JSON or YAML files. * Metadata key accepts JSON or YAML files besides already accepting hardware requirements. * CLI option no longer accepts `key=value` form, it turns out to be much harder to merge with other forms. It is trivial to rewrite it as JSON. Related to #3542.
happz
force-pushed
the
hardware-from-file-or-blob
branch
from
e973289 to
c6996af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
key=valueform, it turns out to be much harder to merge with other forms. It is trivial to rewrite it as JSON.Related to #3542.
Pull Request Checklist