Make documentation building more deterministic#4862
Open
LecrisUT wants to merge 1 commit into
Open
Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
added
the
ci | full test
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the documentation configuration by removing dynamic theme loading, environment variable overrides for styles, and the readthedocs-sphinx-ext dependency. Feedback indicates that removing the sys.path modification may break autodoc and local extension discovery if the package is not pre-installed in the build environment.
I am having trouble creating individual review comments. Click here to see my feedback.
docs/conf.py (93)
Removing sys.path.insert breaks autodoc and local extension discovery if the package is not installed in the environment. Ensure tmt and tmt_setup remain importable in the build environment, or consider keeping the path manipulation for local development convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really think we have useful usecases for this and it would be better to be able to replicate the exact documentation state we see in RTD. If the user wants to play around with the themes, they should do it by changing the dependencies, files live.