Skip to content

Help plans/friends pick the correct version of tmt to test against #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LecrisUT wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Help plans/friends pick the correct version of tmt to test against #4841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b64708
Pick the right tmt sources for friends plan
LecrisUT Apr 29, 2026
39ffd7c
Make the top-level plan selectable for simpler extension
LecrisUT Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions plans/friends/beakerlib.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ description:
beakerlib is working as expected. This plan is run for
upstream pull requests in the beakerlib repository.

discover:
how: fmf
url: https://github.com/teemtee/tmt
discover+:
filter: "tag:beakerlib & tag:-provision-only"

link:
Expand Down
25 changes: 25 additions & 0 deletions plans/friends/main.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,31 @@
/:
select: true

execute:
how: tmt

discover:
how: fmf
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Add the default url to the base discover configuration. This ensures that the plans can still find the tests when imported into other repositories, maintaining the behavior previously defined in individual plan files.

    how: fmf
    url: https://github.com/teemtee/tmt


adjust:
- when: initiator == packit
because: >
We want to test against the tmt main branch
prepare+:
- order: 40
how: install
copr: "@teemtee/latest"
discover+:
url: https://github.com/teemtee/tmt
ref: main
- when: initiator == fedora-ci
because: >
We want to test against the source in Fedora
discover+:
dist-git-source: true
url: https://src.fedoraproject.org/rpms/tmt.git
ref: $@{dist-git-branch}
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Use the correct FMF variable expansion syntax @{...}. The $ prefix is not standard for FMF variables and will likely cause the expansion to fail or result in an incorrect reference.

      ref: @{dist-git-branch}


prepare:
# Install jq and yq for cleaner tests
- how: install
Expand Down
8 changes: 3 additions & 5 deletions plans/friends/podman.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,13 @@ description:
is supposed to be run for podman, crun, container-selinux and
friends pull requests to prevent introducing breaking changes.

discover:
how: fmf
url: https://github.com/teemtee/tmt
discover+:
filter: "tag:podman"
adjust-tests:
- check: avc

prepare:
name: enable-epel
prepare+:
- name: enable-epel
how: feature
epel: enabled
order: 20
Expand Down
Loading