Running tmt clean will now show disk space freed#4801
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements disk space reporting for the clean command by adding utilities to calculate and format file sizes. The cleaning logic for workdirs and testcloud images now logs the amount of space freed, supported by new test assertions. Feedback recommends using lstat to prevent symlink traversal during size calculation and employing floating-point arithmetic in format_size to ensure accurate unit conversion.
happz
reviewed
Apr 15, 2026
happz
reviewed
Apr 15, 2026
LecrisUT
approved these changes
May 11, 2026
therazix
approved these changes
May 11, 2026
AthreyVinay
force-pushed
the
avinay-clean-command-disk-space
branch
from
c4b334a to
dc78e5a
Compare
happz
reviewed
May 12, 2026
happz
reviewed
May 12, 2026
happz
approved these changes
May 14, 2026
psss
reviewed
May 14, 2026
psss
force-pushed
the
avinay-clean-command-disk-space
branch
from
c13bcb5 to
68725ab
Compare
psss
approved these changes
May 14, 2026
Member
psss
left a comment
psss
left a comment
There was a problem hiding this comment.
Works nice! Thanks for implementing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #4593
Pull Request Checklist