Repository navigation
Name the stall run's resolve time for what it measures - #1
Merged
Merged
Conversation
fast_burn_resolved_after_resume_s counted from when the jobs were healthy again, not from the unpause. It is now fast_burn_resolved_after_jobs_running_s, and fast_burn_resolved_after_resume_s is the time since the unpause. For the committed run that is the sum of the two waits, because the second began the moment the first returned: 44.15, 46.49 and 45.33 s, the 44-46 s that MEASUREMENTS.md already reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fast_burn_resolved_after_resume_swas measured from the moment the jobs were healthy again, not from the unpause, so its median (27.77 s) read as time-to-clear after the stall when it is not.fast_burn_resolved_after_jobs_running_s.fast_burn_resolved_after_resume_sis now the time since the unpause, recorded directly inmeasure.py.results/stall.json, that value is the sum of the two waits (44.15, 46.49 and 45.33 s; median 45.33 s), because the second wait began the moment the first returned.MEASUREMENTS.md already reports 44–46 s after the unpause and does not change.