Skip to content

Conversation

@justlilith
Copy link

The cyberpunk and wireframe themes were generated with a slightly invalid property, fontfamily, rather than font-family. This PR fixes the property to prevent downstream build warnings concerning unsupported/invalid CSS properties.

It seems to be an issue stemming from Daisy removing the font families from those two themes upstream (https://github.com/saadeghi/daisyui/blob/de213728084450b81d683cb01795205a3b518941/packages/docs/src/routes/(routes)/docs/v5/%2Bpage.md?plain=1#L796).

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2025

🦋 Changeset detected

Latest commit: 8af5e3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@layerstack/tailwind Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@techniq
Copy link
Owner

techniq commented Dec 30, 2025

@justlilith thanks! care to add a changeset with pnpm changeset to trigger the CI to update the CHANGELOG and trigger a release?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
layerstack ✅ Ready (View Log) Visit Preview 1996f09

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 30, 2025

Open in StackBlitz

@layerstack/svelte-actions

npm i https://pkg.pr.new/@layerstack/svelte-actions@97

@layerstack/svelte-state

npm i https://pkg.pr.new/@layerstack/svelte-state@97

@layerstack/svelte-stores

npm i https://pkg.pr.new/@layerstack/svelte-stores@97

@layerstack/svelte-table

npm i https://pkg.pr.new/@layerstack/svelte-table@97

@layerstack/tailwind

npm i https://pkg.pr.new/@layerstack/tailwind@97

@layerstack/utils

npm i https://pkg.pr.new/@layerstack/utils@97

commit: 1996f09

@techniq
Copy link
Owner

techniq commented Dec 30, 2025

@justlilith we could also remove the font-family entirely as well, since daisyUI 5 also no longer sets these.

@justlilith
Copy link
Author

@techniq good point; I removed the font family altogether now (and added a changeset; I hope I did so correctly, as it's my first time)

@techniq
Copy link
Owner

techniq commented Dec 30, 2025

@techniq good point; I removed the font family altogether now (and added a changeset; I hope I did so correctly, as it's my first time)

Looks good! Thanks for the PR!

[data-theme="cyberpunk"] {
color-scheme: light;
fontfamily:
font-family:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we should remove them from here as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, all done c:

@techniq
Copy link
Owner

techniq commented Dec 30, 2025

At some point we might need to update the CLI scripts that generates these from skeleton/daisy UI source, but it's currently only ran on demand and TBH I'm not sure if/when we'll regenerate again as they don't change often (or need to be 100% in sync).

@techniq techniq merged commit 6c49ffe into techniq:next Dec 30, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Dec 30, 2025
@techniq
Copy link
Owner

techniq commented Dec 30, 2025

Just deployed @layerstack/tailwind@2.0.0-next.22. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants