This repository was archived by the owner on Nov 12, 2026. It is now read-only.
Repository navigation
Tailscale app: settings gear and edit sheet for each VPN - #58
Merged
Merged
Conversation
Each VPN row gets a settings gear (emblem-system-symbolic, tooltip and accessible label) that opens a sheet: server, username, password, IPsec pre-shared key, Send all traffic over VPN connection, Remember passwords (on by default). Secret boxes start empty; empty keeps the stored value. Saves with NetworkManager's D-Bus Update2, so secrets never appear on a command line or in a log; a blank secret that can't be read back stops the save instead of wiping it. Checked against a throwaway VPN with fake secrets, then deleted it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner request: a settings button next to BFS to add or change its passwords.
emblem-system-symbolic, tooltip and accessible label) that opens an edit sheet with: server, username, password, IPsec pre-shared key (L2TP), Send all traffic over VPN connection, and Remember passwords.Settings.Connection.Update2(to disk). Secrets never appear on a command line (ps) or in a log. A blank box keeps the stored secret, read back withGetSecretsinside the app. If that read fails, the save stops with a message rather than wiping the secret.Checked: tests, clippy clean, fixture renders of the row and the empty sheet (in the README). I also ran the save code against a throwaway L2TP connection with fake secrets: server, username and never-default were written and both secrets stored; a second save with blank boxes kept them. Then I deleted the test connection. BFS was not touched. Installed locally, and the app restarted by PID.
🤖 Generated with Claude Code