Repository navigation
Library player: remember speed, add end-of-chapter sleep timer - #9
Merged
Merged
Conversation
The library player reset to 1x on every load, while the rails page already saved sonder.player.rate. Both players now share that key. The sleep timer offered End of part/book but not End of chapter, though chapter markers are loaded. It now offers End of chapter while a chapter is playing. A seek far past the chapter end follows the new chapter instead of pausing at once, and loading another book clears it. Closes findings 15 and 16 in docs/ux-review-2026-11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leftovers from the 2026-11 UX review (
docs/ux-review-2026-11/README.md, findings 15 and 16).sonder.player.rate, the key the rails page already uses, so a speed chosen on either player sticks. Unknown values fall back to 1×.Testing
node --test server/internal/httpapi/web/library.test.cjs: 103 pass, 2 of them new (chapter-end pause, seek-past follow, hidden without chapters, speed saved).🤖 Generated with Claude Code