This repository was archived by the owner on Nov 12, 2026. It is now read-only.
Repository navigation
Polish native Messages favorites, launcher and verification-code offers - #351
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages needs a visible native launcher, a four-across favorites section, and an explicit way to use SMS verification codes. This adds a photo/initials favorites grid with a horizontal divider, fixes the missing Applications icon, and installs a separate near-pointer code helper with a conflict-aware shortcut and scoped uninstall.
The helper inserts into revalidated native AT-SPI EditableText fields without submitting forms. Chromium does not expose that editing interface: Brave gets explicit Copy Code, then the popup closes for manual paste. Direct browser autofill still needs an extension. Codes expire after five minutes and remain in RAM; clipboard writes require the owner's action. Existing phone/notification services and Messages drafts are preserved.
Validation: 17 isolated code checks pass, including actual Return-to-native-field insertion, private Brave clipboard copy with unchanged DOM/submit counters, expiry/password/domain checks and shortcut preservation. 15 isolated Messages GUI checks pass, including four-column wrapping, selection/draft retention and search/divider behavior. Light/dark/narrow fixtures reviewed; native installer, shell syntax and ShellCheck pass. Launcher visibility/icon resolution and existing-window activation verified. Code service installed/active with Shift+Super+V; grid staged for next Messages launch. Owner sign-in insertion, pointer/focus behavior on the running compositor and session restart remain unqualified. No real test texts sent. Apple pin export remains separately owner-qualified work after merged #349.
Merge qualification: all checks relevant to this change passed, including the new native-code suite and Linux pin/UI tests. The only pending job is the macOS 26 ARM reader, queued for hosted capacity. The entire macOS-visit directory is byte-identical to merged dev/#349, whose macOS 26 ARM reader passed. Current-head macOS 15 and Intel 26 also passed. The dev branch has no required status-check protection. No failing check is bypassed; the queued job remains pending and is not reported as passed.