Skip to content

chore(node): update Node.js version to 24.18.1 #10555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GiladShoham wants to merge 10 commits into
base: master
Choose a base branch
from
Open

chore(node): update Node.js version to 24.18.1 #10555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3234caa
chore(node): update Node.js version to 24.6.0
GiladShoham Aug 17, 2025
9204361
fix: update recommended and supported Node.js versions to <25.0.0
GiladShoham Aug 17, 2025
b1d719d
Merge branch 'master' into chore/update-nodejs-24-6-0
GiladShoham Dec 14, 2025
87082b6
Merge master and update Node.js to 24.13.0
davidfirst Jan 22, 2026
04a2f61
fix: correct MDX comment syntax and exclude from prettier
davidfirst Jan 22, 2026
98a8da0
Merge branch 'master' into chore/update-nodejs-24-6-0
GiladShoham Feb 11, 2026
24261fd
Merge branch 'master' into chore/update-nodejs-24-6-0
GiladShoham Jun 10, 2026
7c4a283
Merge branch 'master' into chore/update-nodejs-24-6-0
GiladShoham Aug 2, 2026
1a07c39
chore(node): bump Node.js to 24.18.1
GiladShoham Aug 2, 2026
aaaf52a
revert: drop unrelated MDX/prettierignore changes to keep branch scop…
GiladShoham Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ version: 2.1
# Base configurations
default_image: &default_image
docker:
- image: cimg/node:22.22.0
- image: cimg/node:24.18.1

default_resource_class: &default_resource_class
resource_class: medium
Expand Down Expand Up @@ -324,13 +324,13 @@ commands:
windows_set_node_version:
parameters:
version:
default: 22.22.0
default: 24.18.1
type: string
steps:
- run: choco upgrade nvm -y
- run: nvm -v
- run: nvm install 22.22.0
- run: nvm use 22.22.0
- run: nvm install 24.18.1
- run: nvm use 24.18.1
- run: node -v

windows_add_bvm_to_path:
Expand Down Expand Up @@ -371,7 +371,7 @@ commands:
default: 'BASE_IMAGE'
type: string
docker_build_base_image_arg_value:
default: 'node:22.22.0'
default: 'node:24.18.1'
type: string
image_name:
default: 'bitcli/bit'
Expand Down Expand Up @@ -404,7 +404,7 @@ commands:
default: 'BASE_IMAGE'
type: string
docker_build_base_image_arg_value:
default: 'node:22.22.0'
default: 'node:24.18.1'
type: string
image_name:
default: 'bitcli/bit'
Expand Down Expand Up @@ -1200,27 +1200,27 @@ jobs:
path: index.json

# ========== Docker Jobs ==========
docker_build_node_22:
docker_build_node_24:

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Aug 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Dangling circleci job refs 🐞 Bug ☼ Reliability

CircleCI workflow harmony_deploy_manual still invokes
docker_build_node_22/docker_non_root_build_node_22/server_docker_build_node_22, but this PR
renames those jobs to *_node_24, leaving the manual deploy workflow referencing undefined jobs and
failing configuration validation/execution.
Agent Prompt 
## Issue description
CircleCI jobs were renamed from `*_node_22` to `*_node_24`, but the `harmony_deploy_manual` workflow still references the old job names, which no longer exist.

## Issue Context
The renamed job definitions exist as `docker_build_node_24`, `docker_non_root_build_node_24`, and `server_docker_build_node_24`.

## Fix Focus Areas
- .circleci/config.yml[1636-1676]
- .circleci/config.yml[1202-1248]

## Implementation notes
- In `harmony_deploy_manual`, replace:
  - `docker_build_node_22` -> `docker_build_node_24`
  - `docker_non_root_build_node_22` -> `docker_non_root_build_node_24`
  - `server_docker_build_node_22` -> `server_docker_build_node_24`
- Update `requires:` references accordingly (e.g., `server_docker_build_node_24` should require `docker_build_node_24`).
- Run CircleCI config validation after the change.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

machine:
image: ubuntu-2004:202111-02
steps:
- attach_workspace:
at: ./
- docker_build_and_push:
docker_build_base_image_arg_value: "node:22.22.0"
docker_tag_suffix: "-node-22.22.0"
docker_build_base_image_arg_value: "node:24.18.1"
docker_tag_suffix: "-node-24.18.1"

docker_non_root_build_node_22:
docker_non_root_build_node_24:
machine:
image: ubuntu-2004:202111-02
steps:
- attach_workspace:
at: ./
- docker_build_and_push:
docker_build_base_image_arg_value: "node:22.22.0"
docker_build_base_image_arg_value: "node:24.18.1"
image_name: "bitcli/bit-non-root"
docker_file_name: "Dockerfile-bit-non-root"
docker_tag_suffix: "-node-22.22.0"
docker_tag_suffix: "-node-24.18.1"

docker_build_alpine:
machine:
Expand All @@ -1229,22 +1229,22 @@ jobs:
- attach_workspace:
at: ./
- docker_build_and_push:
docker_build_base_image_arg_value: "node:22.22.0-alpine"
docker_build_base_image_arg_value: "node:24.18.1-alpine"
# image_name: "bitcli/bit-alpine"
docker_file_name: "Dockerfile-bit-alpine"
docker_tag_suffix: "-alpine-node-22.22.0"
docker_tag_suffix: "-alpine-node-24.18.1"

server_docker_build_node_22:
server_docker_build_node_24:
machine:
image: ubuntu-2004:202111-02
steps:
- attach_workspace:
at: ./
- docker_build_and_push:
docker_build_base_image_arg_value: "`npm show @teambit/bit version`-node-22.22.0"
docker_build_base_image_arg_value: "`npm show @teambit/bit version`-node-24.18.1"
image_name: "bitcli/bit-server"
docker_file_name: "Dockerfile-bit-server"
docker_tag_suffix: "-node-22.22.0"
docker_tag_suffix: "-node-24.18.1"

# ========== Windows Jobs ==========
windows_checkout_code:
Expand Down Expand Up @@ -1391,9 +1391,9 @@ jobs:
# - run: node -v
# - run: npm -v
# - run: yarn -v
# # - run: choco install nodejs --version 22.22.0
# # - run: choco install nodejs --version 24.18.1
# # - run: node -v
# - run: cinst nodejs --version 22.22.0
# - run: cinst nodejs --version 24.18.1
# - run: node -v

# ========================================
Expand Down Expand Up @@ -1521,18 +1521,18 @@ workflows:
- bundle_version_macos
- bundle_version_windows
- checkout_code # This is needed to generate index.json
- docker_build_node_22:
- docker_build_node_24:
requires:
- harmony_publish_to_gcloud
- docker_build_alpine:
requires:
- harmony_publish_to_gcloud
- docker_non_root_build_node_22:
- docker_non_root_build_node_24:
requires:
- harmony_publish_to_gcloud
- server_docker_build_node_22:
- server_docker_build_node_24:
requires:
- docker_build_node_22
- docker_build_node_24
- e2e_test_bbit:
requires:
- setup_harmony
Expand Down Expand Up @@ -1616,22 +1616,22 @@ workflows:
- bundle_version_macos
- bundle_version_windows
- checkout_code # This is needed to generate index.json
- docker_build_node_22:
- docker_build_node_24:
requires:
- harmony_deploy_approval_job
- harmony_publish_to_gcloud
- docker_build_alpine:
requires:
- harmony_deploy_approval_job
- harmony_publish_to_gcloud
- docker_non_root_build_node_22:
- docker_non_root_build_node_24:
requires:
- harmony_deploy_approval_job
- harmony_publish_to_gcloud
- server_docker_build_node_22:
- server_docker_build_node_24:
requires:
- harmony_deploy_approval_job
- docker_build_node_22
- docker_build_node_24

# Manual deploy workflow: same jobs as harmony_deploy, without the approval gate.
# Trigger from the CircleCI web app (or API) on master with run_deploy=true.
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-teambit-bit/Dockerfile-bit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=node:22.14.0
ARG BASE_IMAGE=node:24.18.1
FROM $BASE_IMAGE
USER root

Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-teambit-bit/Dockerfile-bit-alpine
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=node:22.22.0-alpine
ARG BASE_IMAGE=node:24.18.1-alpine
FROM $BASE_IMAGE
ARG BIT_VERSION='1.11.31'
# Install Git
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-teambit-bit/Dockerfile-bit-non-root
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=node:22.14.0
ARG BASE_IMAGE=node:24.18.1
FROM $BASE_IMAGE
RUN adduser --disabled-password --gecos '' user
RUN chown -R user /usr/local/
Expand Down
4 changes: 2 additions & 2 deletions workspace.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@
"@pnpm/util.lex-comparator": "3.0.2",
"@pnpm/config.nerf-dart": "1.0.1"
},
"nodeVersion": "22.22.0",
"nodeVersion": "24.18.1",
"engineStrict": true,
// This is a temporary workaround to fix "bit compile" on macOS and Windows.
// "bit compile" breaks node_modules when hard links are used.
Expand Down Expand Up @@ -806,7 +806,7 @@
"packageJson": {
"name": "@teambit/{name}", // @teambit/discovery.ui.sidebar
"bvm": {
"node": "22.22.0"
"node": "24.18.1"
},
"engines": {
"node": ">=18.12.0"
Expand Down