Merged
Conversation
…d add (unused) constants for rotation offsets in lineup
3 tasks
godmar
previously approved these changes
Oct 24, 2025
godmar
left a comment
godmar
left a comment
There was a problem hiding this comment.
I checked for other uses of driveAlongTrackOffset (found some in demo, hitl, test_drivebase), and discovered the *CameraIndex constants which might be applicable here. Decide if this is worth addressing now.
src/main/java/frc/robot/subsystems/drive/states/LineupState.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/drive/states/LineupState.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for the quick, short-notice review, by the way! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow separate AlongTrack offsets per camera and add a heading offset for each camera when scoring in lineup.