Add a test for an abrupt completion when getting "flags" property in String.prototype.matchAll - #5111
Open
Koreangung15 wants to merge 2 commits into
Open
Add a test for an abrupt completion when getting "flags" property in String.prototype.matchAll#5111Koreangung15 wants to merge 2 commits into
Koreangung15 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for abrupt completion propagation resulting from the Get operation performed in step 3.b.i of String.prototype.matchAll.
String.prototype.matchAll determines whether
regexpOrPatternis a regular expression by performing IsRegExp operation. If IsRegExp returnstrue, it retrieves the "flags" property ofregexpOrPattern.This test sets the "Symbol.match" property to
true, causing IsRegExp to returntrue, and defines "flags" property as a throwing getter. So, accessing this property causes the Get operation to return an abrupt completion, which is then propagated.Existing test/built-ins/String/prototype/matchAll/flags-nonglobal-throws.js and test/built-ins/String/prototype/matchAll/flags-undefined-throws.js cover failures after the "flags" property has been successfully retrieved. They do not cover an abrupt completion from retrieving the property itself.