Add a test for abrupt completion from the target's length getter in Function.prototype.bind - #5110
Open
Koreangung15 wants to merge 2 commits into
Open
Add a test for abrupt completion from the target's length getter in Function.prototype.bind#5110Koreangung15 wants to merge 2 commits into
Koreangung15 wants to merge 2 commits into
Conversation
…unction.prototype.bind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test case verifying that Function.prototype.bind propagates an abrupt completion produced by Get in step 6.a.
Function.prototype.bind checks whether
target(thisvalue) has an own "length" property. If it does, step 6.a obtainstargetLengthby performingGet(target, "length"). Therefore, if the target's "length" property is an accessor property whose getter throws an exception, Function.prototype.bind must propagate that exception.The filename and test structure mirror test/built-ins/Function/prototype/bind/instance-name-error.js, which verifies abrupt completion propagation while accessing the target's "name" property, while this PR adds the corresponding test for the target's "length" property.