Add return abrupt from LengthOfArrayLike in toLocaleString - #5109
Open
Koreangung15 wants to merge 2 commits into
Open
Add return abrupt from LengthOfArrayLike in toLocaleString#5109Koreangung15 wants to merge 2 commits into
Koreangung15 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds coverage for cases where LengthOfArrayLike, called in step 2 of Array.prototype.toLocaleString, returns an abrupt completion originating from Get or ToLength.
Array.prototype.toLocaleString converts its this value to an object and obtains that object's length by calling LengthOfArrayLike. Because the method is generic, a caller may supply an arbitrary array-like object as the this value, so an exception must be propagated in both of the following cases:
The equivalent case is covered for other methods that reach LengthOfArrayLike in the same way: Array.prototype.fill in test/built-ins/Array/prototype/fill/return-abrupt-from-this-length.js. However, it seems that current test cases in Array.prototype.toLocaleString are not checking whether abrupt completion of LengthOfArrayLike function is correctly propagated.