Feat/#220 팀 페이지 내 미구현 기능 구현#221
Merged
Merged
Conversation
🎨 UI Review (Chromatic)
|
zaenny
reviewed
Apr 16, 2026
Comment on lines
+1
to
+2
| "use client"; | ||
|
|
Collaborator
There was a problem hiding this comment.
use client가 붙어 있는데, AsyncBoundary가 ssr: false로 dynamic import 되어있어서 제거해도 괜찮지않나요?
Contributor
Author
There was a problem hiding this comment.
errorFallback에서 화살표 함수 prop을 전달하는게, 서버 컴포넌트에서는 함수를 전달 못해서 에러가 발생하더라고요
zaenny
reviewed
Apr 16, 2026
| 목표 | ||
| </h2> | ||
| <span className="typography-body-1 ml-[-8px] font-medium text-gray-400"> | ||
| {goalList.length}개 |
Collaborator
There was a problem hiding this comment.
혹시 목표의 전체 개수가 필요한 건가요, 아니면 현재 불러온 데이터의 개수를 표출하는 건가요? 무한스크롤이라 스크롤 전엔 일부만 로드되어있을것 같아서요!
Contributor
Author
There was a problem hiding this comment.
그러네요 이건 제가 놓친거 같습니다
zaenny
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#220
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)